Skip to content

fix: fetch Croller from Maven Central #2646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
AsCress merged 1 commit into from
Mar 15, 2025
Merged

fix: fetch Croller from Maven Central #2646

AsCress merged 1 commit into from
Mar 15, 2025

Conversation

@AsCress
Copy link
Collaborator

@AsCress AsCress commented Mar 13, 2025 •
edited by sourcery-ai bot
Loading

Summary by Sourcery

Bug Fixes:

  • Fix dependency fetching by switching from a local aar file to fetching Croller from JitPack.

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Mar 13, 2025 •
edited
Loading

Reviewer's Guide by Sourcery

The pull request updates the dependency management for the Croller library by switching from a local file dependency to fetching it directly from JitPack. This change ensures that the project uses the specified version of Croller from a remote repository, improving maintainability and consistency.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Updated the dependency management for Croller library.
  • Removed the local file dependency for Croller.
  • Added a new dependency to fetch Croller from JitPack using the specified version.
 app/build.gradle.kts
Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@AsCress AsCress added the Fix Solution to an existing issue in app label Mar 13, 2025
sourcery-ai[bot]
sourcery-ai bot reviewed Mar 13, 2025
View reviewed changes
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @AsCress - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good
Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@AsCress AsCress requested a review from bessman March 13, 2025 16:02
@github-actions
Copy link
Contributor

github-actions bot commented Mar 13, 2025 •
edited
Loading

Build successful. APKs to test: https://github.com/fossasia/pslab-android/actions/runs/13874555756/artifacts/2757950120

@AsCress AsCress force-pushed the fix_lib branch 2 times, most recently from 5c1b973 to 451c628 Compare March 15, 2025 05:12
@AsCress AsCress changed the title fix: fetch Croller from jitpack fix: add submodule for Croller Mar 15, 2025
@AsCress AsCress force-pushed the fix_lib branch 10 times, most recently from 2ba0fd2 to 3b91364 Compare March 15, 2025 16:16
@AsCress AsCress changed the title fix: add submodule for Croller fix: fetch Croller from Maven Central Mar 15, 2025
@AsCress
Copy link
Collaborator Author

AsCress commented Mar 15, 2025

Croller is now fetched from the Maven Central repository, as JCenter has shutdown.

@AsCress AsCress merged commit 2bc0c10 into fossasia:development Mar 15, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

@bessman bessman bessman approved these changes

Assignees

No one assigned

Labels

Fix Solution to an existing issue in app

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AsCress @bessman